Conversation
|
Hey @ricochet thanks for the contribution! So the implementation looks fantastic so far -- broken tests aside (it looks like there's a small use-before-definition, probably an easy fix). That said, I think that we might be better served by using the functionality already present in jco's build of Basically, the This is actually already supported (see the form of That should be the last argument to the |
fa97e09 to
e268ec7
Compare
|
Closing this for now, since we do have a tracking issue, and the fix needs to actually be made upstream in jco. In the case that the new rust-based componentize-js makes it in before this is finished, the impl will also look completely different. |
Fixes #301